4/x: Add per-model cache selection via RuntimeSpec cache_dir option (#18777)#18777
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Apr 9, 2026
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18777
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 5 Unrelated FailuresAs of commit 6bbf2f9 with merge base be370a1 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92458709. |
digantdesai
approved these changes
Apr 8, 2026
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
meta-codesync
Bot
changed the title
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 8, 2026
…ytorch#18777) Summary: This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
from
70dc596 to
ff0f1fe
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 8, 2026
…ytorch#18777) Summary: This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
from
ff0f1fe to
0c4940c
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 8, 2026
…ytorch#18777) Summary: Pull Request resolved: pytorch#18777 This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
from
0c4940c to
fe2002c
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 8, 2026
…ytorch#18777) Summary: This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
2 times, most recently
from
239b680 to
239b2d0
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 9, 2026
…ytorch#18777) Summary: This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 9, 2026
…ytorch#18777) Summary: This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
from
239b2d0 to
40a4d7f
Compare
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Apr 9, 2026
…ytorch#18777) Summary: Pull Request resolved: pytorch#18777 This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
from
40a4d7f to
09ad66d
Compare
…ytorch#18777) Summary: This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md [ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ] The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does. Reviewed By: digantdesai Differential Revision: D92458709
metascroy
force-pushed
the
export-D92458709
branch
from
09ad66d to
6bbf2f9
Compare
jpiat
pushed a commit
to jpiat/executorch
that referenced
this pull request
Apr 14, 2026
…ytorch#18777) Differential Revision: D92458709 Pull Request resolved: pytorch#18777
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is diff 4/9 to implement the new caching system for CoreML, following the design doc here: fbcode/executorch/backends/apple/coreml/docs/new_cache_design.md
[ gdoc version: https://docs.google.com/document/d/1aKwTNj-L3-sAyBetL92RwJdSsSwA4KhvAQ3FO1zbguE/edit?tab=t.0#heading=h.3ecu6rvzx1z3 ]
The design doc contains detailed plans for each diff in the stack, see https://fburl.com/gdoc/qpok9g0i for what this diff does.
Reviewed By: digantdesai
Differential Revision: D92458709